Fix: Exit http server on php exit #1714
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Calling the
php.exit
caused a hanging connection. This had affect in tests, and leaving open connections around.Implementation details
Attach the HTTP server that we spawn to handle websocket connections to the PHP instance.
When we call
.exit
we use the attached instance to close the connections.Testing Instructions (or ideally a Blueprint)
php-wasm/node
andphp-wasm/universal
/dist
php-wasm folder and runnpm link
npm link @php-wasm/node
andnpm link @php-wam/universal
npm install