Fix builder redirect #1693
Merged
Fix builder redirect #1693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
brandonpayton added [Type] Bug Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
The
/builderto/builder/builder.htmlredirect isn't working because nginx doesn't give us a chance to do custom redirects when:This PR fixes that redirect.
Implementation details
As a workaround, this PR adds a
/builder/index.phpfile so nginx will invoke PHP and give us an opportunity to apply custom redirects.This PR also fixes a few uses of deprecated string interpolation syntax.
Testing
Tested manually on the web host