Reinstantiate Changelog generation in GitHub CI #1657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
As reported in #1654, the automated Changelog generation stopped working in May. The root cause? The CI job didn't explicitly pass the version number to `npm run changelog`. This PR solves that and backfills all the missing changelog entries. ## Testing instructions Merge this PR, release new NPM packages, confirm the changelog was updated. Unfortunatly there's no better way to verify it works :(
adamziel added [Type] Bug 
| Let's give it a try! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
The automated Changelog generation stopped working in May.
The root cause? The CI job didn't explicitly pass the version number to
npm run changelog. This PR solves that and backfills all the missing changelog entries.Fixes #1654
Testing instructions
Merge this PR, release new NPM packages, confirm the changelog was updated. Unfortunatly there's no better way to verify it works :(
cc @brandonpayton