Disable website features that don't work while offline #1607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bgrgicak added [Feature] Import Export [Aspect] Website [Package][@wp-playground] Website and removed [Feature] Import Export labels 
| Looking good! In cc62c1d I've disabled more menu options and added a message to explain why everything is greyed out:   |
adamziel approved these changes Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Playground will soon be able to work offline , but some features like GitHub exports still require internet to work.
When offline users shouldn't be able to:
Some of these might get offline support in the future, but they won't be available in v1.
Implementation details
The
PlaygroundReduxStatestore now has aofflineselector.This selector is used by the Customize Playground form and the menu to disable buttons for functionalities that don't work offline.
Testing Instructions (or ideally a Blueprint)