Build: Use regular expressions to mark packages as external #1589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
adamziel added [Type] Bug adamziel added a commit that referenced this pull request Jul 9, 2024
Follows up on #1589 and #1586 Treating package IDs matching `node_modules` as external works, but causes Rollup to substitute the module name with the absolute module path on the host machine, e.g. `import "ini"` becomes `import "/home/runner/work/wordpress-playground/wordpress-playground/node_modules/ini/lib/ini.js"` which is not what we want. This PR sources the external packages names from the package.json file to both treat all these imports as external AND preserve their original import identifier. ## Testing instructions Run nx build php-wasm-node and confirm the resultingdist/packages/php-wasm/index.js file and other built npm-published modules do import external modules using their name, not their absolute path.
adamziel added a commit that referenced this pull request Jul 9, 2024
Follows up on #1589 and #1586 Treating package IDs matching `node_modules` as external works, but causes Rollup to substitute the module name with the absolute module path on the host machine, e.g. `import "ini"` becomes `import "/home/runner/work/wordpress-playground/wordpress-playground/node_modules/ini/lib/ini.js"` which is not what we want. This PR sources the external packages names from the package.json file to both treat all these imports as external AND preserve their original import identifier. It also adds the required `package.json` building steps to the `@php-wasm/universal` package and makes the `@php-wasm/stream-compression` package public to ensure the published packages will reference the correct dependencies. ## Testing instructions Run nx build php-wasm-node and confirm the resultingdist/packages/php-wasm/index.js file and other built npm-published modules do import external modules using their name, not their absolute path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Follows up on #1586
Extracting external packages names from the
package.jsonfiles did not work as expected due tocwdmisconfiguration in CI. This PR replaces that logic with a regexp matching the name of the packages from this monorepo to avoid maintaining the paths entirely.Testing instructions
Run
nx build php-wasm-nodeand confirm the resultingdist/packages/playground/client/index.jsfile and other built npm-published modules do not bundle any external modules. The only exception should be theclipackages.