PHP: Remove the MODE_EVAL_CODE execution mode #1433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Removes the special MODE_EVAL_CODE in which the PHP code to evaluate is fed to the interpreter as a string. Inline code snippets are now written to a special file called `/internal/eval.php` and executed as regular PHP files. ## Rationale PHP does not correctly load the php.ini file when the code is passed as a string. This change also reduces the number of forks in the most cricitcal code path in the project – PHP execution. ## Remaining work * Rebuild all the PHP bundles, not just 8.0 ## Testing instructions Confirm the CI checks pass
adamziel added [Type] Enhancement …asm_remove_run_php_function
…th redirect 301 when /wordpress/load.php is included
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Removes the special MODE_EVAL_CODE in which the PHP code to evaluate
is fed to the interpreter as a string. Inline code snippets are now
written to a special file called
/internal/eval.phpand executedas regular PHP files.
Rationale
PHP does not correctly load the php.ini file when the code is passed as
a string.
This change also reduces the number of forks in the most cricitcal code
path in the project – PHP execution.
Remaining work
Testing instructions
Confirm the CI checks pass