Boot: Move WordPress zip extraction logic to a common unzipWordPress() utility #1427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ility TODO: Rewrite it in PHP using Zip Streams from the PHP Blueprints library, find nested WordPress whether it's in a doubly compressed zip archive or a "build" directory. Give the developer some control over it, too, in case there are multiple zipped WordPresses. Or don't and document that.
adamziel added a commit that referenced this pull request May 18, 2024
Replaces a series of custom steps meant to unzip and configure WordPress with passinf the build zip as a preferredVersion. To test, go to the WordPress PR previewer locally and try previewing one of the recent PRs. Confirm the installed WordPress versions is indeed not the latest stable. Do not merge until these PRs are merged: * #1423 * #1424 * #1425 * #1426 * #1427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Moves the WordPress.zip extraction logic to a common utility function called
unzipWordPressand living in the@wp-playground/wordpresspackage. This allows bothremote.htmland Playground CI to boot consistently.This and #1425 unlocks providing WordPress ZIP bundles in Blueprints via
{ "preferredVersion": { "wp": "<URL>" } }.Implementation details and follow-up work
The goal of
unzipWordPress()is to extract a zipped WordPress installation at a specified location in VFS. This isn't a trivial task as WordPress might exist at a root of the zip file, at a nested/wordpressdirectory, in anotherwordpress.zipfile living inside the initialwp.ziparchive, or in any subdirectory of the above. The current implementation covers a few basic cases, but nothing beyond that.Looking forward, we should:
Testing instructions
Confirm the E2E tests pass