Skip to content

Unzip: Only delete a temporary zip file after unzipping, do not delete the original zip #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2024
Merged

Unzip: Only delete a temporary zip file after unzipping, do not delete the original zip #1412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/playground/common/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,15 @@ export const RecommendedPHPVersion = '8.0';
/**
* Unzip a zip file inside Playground.
*/
const tmpPath = '/tmp/file.zip';
export const unzipFile = async (
php: UniversalPHP,
zipPath: string | File,
extractToPath: string
) => {
if (zipPath instanceof File) {
const zipFile = zipPath;
zipPath = '/tmp/file.zip';
zipPath = tmpPath;
await php.writeFile(
zipPath,
new Uint8Array(await zipFile.arrayBuffer())
Expand All @@ -41,8 +42,8 @@ export const unzipFile = async (
php,
`unzip(${js.zipPath}, ${js.extractToPath});`
);
if (php.fileExists(zipPath)) {
await php.unlink(zipPath);
if (php.fileExists(tmpPath)) {
await php.unlink(tmpPath);
}
};

Expand Down