Stop using PHP to serve most static files on WP Cloud #1331
Conversation
| Currently, this PR invokes PHP once per file to ask whether a file needs served by PHP. This is slow and will be changed to invoke PHP once to produce a filtered list of files that need custom treatment. In addition, this PR currently symlinks most static files into the webroot so nginx can serve them directly. All files are actually stored in a secondary folder. This is a bit backwards. Instead, we should place all files that can served directly into the web root and only exclude the files that need special treatment. I am working on both of these changes. |
How slow? The deployment script was taking 10 minutes when tested directly via SSH. This can be made much faster. |
| <?php | ||
| | ||
| // Adapted from https://github.com/nginx/nginx/blob/d8a849ae3c99ee5ca82c9a06074761e937dac6d6/conf/mime.types | ||
| $mime_types = array( |
There was a problem hiding this comment.
Let's reuse this list in the PHPRequestHandler class
There was a problem hiding this comment.
@adamziel, sounds good.
My plan is to create a separate PR where we:
- add a mime-types JSON file
- import it in the TypeScript module for PHPRequestHandler
- use the JSON to generate mime-types.php during deployment
brandonpayton had a problem deploying to playground-wordpress-net-wp-cloud 
GitHub Actions Error brandonpayton had a problem deploying to playground-wordpress-net-wp-cloud GitHub Actions Error brandonpayton had a problem deploying to playground-wordpress-net-wp-cloud GitHub Actions Failure brandonpayton had a problem deploying to playground-wordpress-net-wp-cloud GitHub Actions Failure brandonpayton had a problem deploying to playground-wordpress-net-wp-cloud GitHub Actions Failure brandonpayton had a problem deploying to playground-wordpress-net-wp-cloud GitHub Actions Failure brandonpayton temporarily deployed to playground-wordpress-net-wp-cloud GitHub Actions Inactive | The latest changes cut the |
2 participants
What is this PR doing?
This updates the deploy workflow for WP Cloud so that PHP is no longer used to serve all Playground files.
What problem is it solving?
It is slow and unnecessarily burdensome on server resources to serve static files with PHP by default. This changes deployment so only resources that need redirects or custom headers are served via PHP. Most files do not need this treatment.
How is the problem addressed?
Most of the files are now located where nginx can serve them directly. Only files that need custom serving are set aside where nginx invokes PHP to serve files it cannot find.
Testing Instructions