Progress monitoring: Use a custom instantiateWasm handler to avoid monkey-patching WebAssembly.instantiateStreaming #1305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…nkey-patching WebAssembly.instantiateStreaming Monitors the `.wasm` file download through a custom `instantiateWasm` handler passed to the Emscripten module. Before this PR, Playground "decorated" WebAssembly.instantiateStreaming to monitor the stream progress. This introduced additional complexity in [Loopback Request support](#1287) and so this PR replaces it with a less hacky solution. ## Testing instructions Confirm the E2E tests pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Monitors the
.wasmfile download through a custominstantiateWasmhandler passed to the Emscripten module.Before this PR, Playground "decorated" WebAssembly.instantiateStreaming to monitor the stream progress. This introduced additional complexity in Loopback Request support and so this PR replaces it with a less hacky solution.
Testing instructions
Confirm the E2E tests pass