Skip to content

Breaking: Remove PHPBrowser #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 23, 2024
Merged

Breaking: Remove PHPBrowser #1302

merged 7 commits into from
Apr 23, 2024

Conversation

adamziel
Copy link
Collaborator

@adamziel adamziel commented Apr 23, 2024 •
edited
Loading

Warning

This is breaking change. We need it to support loopback requests.

Removes PHPBrowser, a decorator class over PHPRequestHandler whose sole task was to intercept, remember, and provide cookies for HTTP requests.

Having a class composition complicated the loopback request support PR and so thir PR introduces a CookieStore that does the same task at the PHPRequestHandler level

Migrating your codebase

  1. Remove any mentions of the PHPBrowser class from your code.
  2. Replace all mentions of the PHPBrowser type with PHPRequestHandler.
  3. Replace all mentions of the RequestHandler type with PHPRequestHandler.

It you manually initialize new PHPBrowser(), as in new PHPBrowser(new PHPRequestHandler()), just remove the wrapping new PHPBrowser() call and replace any references to the PHPBrowser type with PHPRequestHandler.

If you load things using the WebPHP.load() or NodePHP.load() API, you don't need to change anything.

Before merging

  1. Start a Changelog with a list of breaking changes.
  2. Document this PR in there.

Testing instructions

Confirm all the unit and E2E tests pass
@adamziel adamziel changed the title Remove PHPBrowser Breaking: Remove PHPBrowser Apr 23, 2024
@adamziel adamziel mentioned this pull request Apr 23, 2024
Merged
@adamziel adamziel force-pushed the remove-php-browser-2 branch from 0c0ccac to 18e70c0 Compare April 23, 2024 18:30
adamziel added 3 commits April 23, 2024 20:30
@adamziel
Remove PHPBrowser
bf77bb0 
Removes PHPBrowser, a decorator class over PHPRequestHandler whose sole task was to intercept, remember, and provide cookies for HTTP requests. Having a class composition complicated the loopback request support PR and so thir PR introduces a CookieStore that does the same task at the PHPRequestHandler level Related to #1287 ## Testing instructions Confirm all the unit and E2E tests pass
@adamziel
Fix an accidental infinite loop in requests
84222a7
@adamziel
Remove maxRedirects, remove the RequestHandler interface
a6c5924
@adamziel adamziel force-pushed the remove-php-browser-2 branch from 18e70c0 to a6c5924 Compare April 23, 2024 18:34
@adamziel
Copy link
Collaborator Author

adamziel commented Apr 23, 2024 •
edited
Loading

@sejas @kozer @wojtekn heads up this is coming, wp-now/studio may or may not require adjusting once it lands.
@adamziel adamziel force-pushed the remove-php-browser-2 branch from 3ec7c22 to eb631d1 Compare April 23, 2024 22:11
@adamziel adamziel requested a review from a team as a code owner April 23, 2024 22:11
@adamziel adamziel merged commit d85edd4 into trunk Apr 23, 2024
@adamziel adamziel deleted the remove-php-browser-2 branch April 23, 2024 22:30
@adamziel adamziel restored the remove-php-browser-2 branch April 23, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking change [Feature] PHP.wasm [Type] Enhancement New feature or request

1 participant

@adamziel