#63170 Tweak e2e test workflow names #9427
Conversation
| The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
johnbillion changed the title 
desrosj left a comment
desrosj left a comment There was a problem hiding this comment.
👍 Just one small doc request.
| fail-fast: false | ||
| matrix: | ||
| LOCAL_SCRIPT_DEBUG: [ true, false ] | ||
| label: [ 'E2E Tests' ] |
There was a problem hiding this comment.
Neat trick! Just disappointing that it needs to be this way for the nesting to work properly.
It's not obvious at first glance why this is here. I'm thinking an inline comment above label briefly explaining why it's there would be good for our future selves.
mukeshpanchal27 left a comment
mukeshpanchal27 left a comment There was a problem hiding this comment.
Nice ✨
Pre-Approving. Let one minor non-blocking feedback
| # Runs the end-to-end test suite. | ||
| e2e-tests: | ||
| name: Test with SCRIPT_DEBUG ${{ matrix.LOCAL_SCRIPT_DEBUG && 'enabled' || 'disabled' }} | ||
| name: ${{ matrix.label }} |
There was a problem hiding this comment.
Nit: As we don't use the label else where can we use label directly here?
| name: ${{ matrix.label }} | |
| name: E2E Tests |
There was a problem hiding this comment.
This is actually a trick to get the UI in GitHub Actions to do what we want. A matrix value is needed in the name directive for proper grouping in the GitHub UI.
3 participants
The test execution has been deleted just to speed up the feedback loop. That bit won't be committed.
Trac ticket: https://core.trac.wordpress.org/ticket/63170