- Notifications
You must be signed in to change notification settings - Fork 3.1k
Updated NPM Dependencies for 6.2 #3913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Hi @NaeemHaque! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
mukeshpanchal27 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @NaeemHaque, Changes look fine to me.
| @desrosj Can you review when you get a moment? |
desrosj left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added one note inline, but there are additional packages that can be updated to the latest versions:
chalkdotenv-expandjson2phpsinonwait-on
I looked quickly and it seems like these are mostly minor maintenance updates and should be fine to update!
| Thanks @NaeemHaque. The changes look good in the individual commits, but it seems the last commit on this PR created some problems. I'm not sure what's happening, but could you take a look and try to fix? There's also now a merge conflict after https://core.trac.wordpress.org/changeset/55150. |
| Hello @desrosj, sorry for this created problem. I've tried to resolve it but didn't. This branch has some conflicts I think you can resolve when merging with the branch trunk. On the other hand, I can create e new branch and update all dependencies again. |
| No worries @NaeemHaque! Thanks for working on this so far. I've created #3968 to resolve those conflicts and push. In the future when you create a PR, there is an option to allow repository maintainers to push to you pull request branch. If you check that, then Core committers can push changes to your pull request! |
| Noted with thanks. |
In 53113:
Updated some NPM dependencies to the latest versions.
This updates several NPM dependencies to the latest versions, including:
grunt-contrib-qunitfrom~6.2.0to~6.2.1qunitfrom~2.19.1to~2.19.4sassfrom^1.55.0to^1.57.1sinonfrom~14.0.1to~14.0.2sinon-testfrom~3.1.4to~3.1.5uglify-jsfrom^3.17.3"to^3.17.4Trac ticket: https://core.trac.wordpress.org/ticket/57535