WhiteSpace/ControlStructureSpacing: prevent fixer removing return type declarations #1319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…e declarations While this will be solved better in the future by a dedicated sniff to check function declarations, in the mean time, return type declarations should not be removed by the fixer in this sniff. And as the placement of the opening brace for function declarations is also checked for by the `Generic.Functions.OpeningFunctionBraceKernighanRitchie` sniff, let's ignore this error for function declarations in this sniff and leave the fixing up to the upstream sniff. Fixes 1202
GaryJones approved these changes Mar 1, 2018
JDGrimes approved these changes Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
While this will be solved better in the future by a dedicated sniff to check function declarations (see #1101) , in the mean time, return type declarations should not be removed by the fixer in this sniff.
And as the placement of the opening brace for function declarations is also checked for by the
Generic.Functions.OpeningFunctionBraceKernighanRitchiesniff, let's ignore this error for function declarations in this sniff and leave the fixing up to the upstream sniff.Fixes #1202