feat: rts from committed changes #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
add a flag to allow checking for tests from changes between commits
matveypashkovskiy suggested changes Mar 25, 2021
use pytest fixture to clean up test code
remove the useless git head commithash parameters from diff functions
change logic of rts to always consider both committed and workdir tests
fix some wrong docstrings for git functions
matveypashkovskiy suggested changes Mar 25, 2021
README.md Outdated
| As a result only tests related to changes in working directory and branch will be executed. | ||
| As a result only tests related to changes in working directory will be executed. | ||
| | ||
| #### Tests from working directory + committed changes |
Contributor
There was a problem hiding this comment.
Let's have the title starting the same way as previous: "Tests from changes in Git working directory + committed changes" to make it clear that it is the same as previous with some extra.
pytest_rts/utils/git.py Outdated
| """Check if a given commithash exists in the Git repository""" | ||
| if not commithash: | ||
| return False | ||
| return commithash in [commit.hash for commit in repo.get_list_commits()] |
Contributor
There was a problem hiding this comment.
- it is better to use
repo.get_commit(commithash)here - print warning if
commithashis provided but doesn't exist in history
pytest_rts/utils/common.py Outdated
| Otherwise the commithash is compared to the current working copy. | ||
| """ | ||
| repo = get_git_repo() | ||
| if not commit_exists(commithash_to_compare, repo): |
Contributor
There was a problem hiding this comment.
Inverted condition is more readable: compare if commit_exists() with if not commit_exists()
simplify checking if a given commit exists for change detection
| *__pycache__* | ||
| runpytest-* | ||
| stderr | ||
| stdout |
Contributor
There was a problem hiding this comment.
What are stderr and stdout here?
Contributor Author
There was a problem hiding this comment.
Files produced by the pytester plugin. I thought ignoring them would make debugging test cases for running working directory changes easier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Here's a version that can check tests from committed changes with
--rts-from-commit=[init commithash]. If it's not provided, only changes in the working directory are checked. A slight problem is that new tests are discovered independently from the workdir/committed option and it would require some extra checking to get things perfectly right.Wrote some testcases for various situations. Also noticed that I created really flaky tests in the last PR because
__pycache__files in the testrepo didn't update between runs. I think I fixed it by clearing them before each test.