feat: run tests from changes in workdir #96
Conversation
select tests based on changed lines in git working directory
pytest_rts/utils/common.py Outdated
| if line_number in changed_lines: | ||
| tests.update( | ||
| strip_pytest_cov_testname(testname) | ||
| for testname in coverage_data.contexts_by_lineno(changed_file)[ |
There was a problem hiding this comment.
it is possible that coverage_data.contexts_by_lineno() queries DB, so it is better to store the resulting value before line 54 to avoid extra queries.
pytest_rts/utils/common.py Outdated
| tests: Set[str] = set() | ||
| for changed_file in file_diffs: | ||
| changed_lines = get_changed_lines(file_diffs[changed_file]) | ||
| for line_number in coverage_data.contexts_by_lineno(changed_file): |
There was a problem hiding this comment.
Would something like that work?
contexts = coverage_data.contexts_by_lineno(changed_file) if not contexts: # is there a better check if dict is empty? continue # skipping diff parsing for uncovered/moved/renamed file changed_lines = get_changed_lines(file_diffs[changed_file]).intersection(contexts.keys()) tests.update( strip_pytest_cov_testname(contexts[line]) for line in changed_lines )There was a problem hiding this comment.
If I read it correctly contexts_by_lineno() opens a connection to DB every time you call it and there is no method to pass several file names and get results. To solve possible performance problems we could:
- read DB directly
- create a PR in coveragepy repo
But let's think about it later.
There was a problem hiding this comment.
Your suggestion seems much better. Working on it.
| Shall we mention in README.md: |
| Yeah I can add it |
improve code for test selection to prevent multiple database calls
simplify testcase for changed lines parsing to get rid of bloat
pass gitrepository object around in functions to prevent extra calls
| Good, I suppose the only thing left to do it is run tests from commits done after |
Here's a version that gets the tests from git working directory as it did previously. So now it should run tests from working directory changes + new tests. Requires
.coveragercfile to be in place withrelative_files=Truewhen initialization is done.Example
.coveragerc:Usage:
.coveragercpytest --cov=<path to code> --cov-context=test.coverageto 'mapping.db`pytest --rts --rts-coverage-db=mapping.db