feat: start pytest-cov integration #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Start using the .coverage file from pytest-cov for rts
run only newly added tests that pytest-cov did not pick up when coverage file was made
test cases for running pytest-rts to find newly added tests
matveypashkovskiy approved these changes Mar 18, 2021
Contributor
matveypashkovskiy left a comment
matveypashkovskiy left a comment There was a problem hiding this comment.
Looks very good! Please fix minor comments if you think that it makes sense/feasible and let's merge it.
Contributor
| wait before merging, I'll double-check that the right version will be published |
Contributor
| Yes the right version will be published: > semantic-release print-version -D version_variable=pytest_rts/__init__.py:__version__ 2.1.0 |
Contributor Author
| Does the release version bump up on every commit or every PR? Should a single PR have a single commit ? |
Contributor
Yes, it bumps minor version on every "feat" commit and patch on every "fix". Everything else doesn't change the version. It is absolutely fine to have several commits in the PR. |
add pytest-cov to install requirements and bump up the coverage threshold
add missing type hints to code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Here's the version that runs only newly added tests as discussed in #92. The integration test uses pytester. For the unit test of
filter_pytest_itemsI couldn't figure out how to build actual an pytestItemso I relied on some fake objects. Don't know if that's a good or a bad thing.closes #92