Skip to content

SqlBuilderMixin: wrap column names in backticks #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2016
Merged

SqlBuilderMixin: wrap column names in backticks #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ dist/
venv/
*.iml
.idea
*.swp

coverage.xml
env/
Expand Down
2 changes: 1 addition & 1 deletion wikia/common/mw_database/build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "1.0.5",
"version": "1.0.6",
"description": "Mediawiki database connector",
"install_requires": [
"MySQL-python==1.2.5",
Expand Down
2 changes: 1 addition & 1 deletion wikia/common/mw_database/query_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def insert(self, table, data, ignore_errors=False):
values = []
sql_data = {}
for column, value in data.items():
columns.append(column)
columns.append('`{}`'.format(column))
sql_value, is_value = self.add_value(value, sql_data, column)
if not is_value:
raise ValueError('insert accepts only value literals')
Expand Down