Fix problem with illegal offset error. #226
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixed #224, #98.
Hello @Webklex!
I've recently got stuck on a problem with the "illegal offset" error while using your package. After debugging and lots of tests performed on real mailboxes, I realized that we have to remove not-message entries from the results array - because these rows don't have a UID field. The
array_searchcan returnfalseor-1when can't find searched value.In our case, the
array_searchreturns-1or (mainly)falseas output, and then, the script was trying to add1to the result. In PHPfalse + 1 = 1.So when the algorithm hadn't been able to find the UID value it thought, that the proper index is 1 (as a result of the
false + 1calculation), which was causing the error.