Use real tls instead of starttls #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Webklex merged 1 commit into Webklex:master from netpok:fix-tls-connection

Nov 17, 2021

Contributor

netpok commented Nov 17, 2021

The current implementation tries to use startls instead of tls.

This is incorrect because

starttls: opens a tcp connection and later upgrades to tls
tls: opens the tls connection and does not need to upgrade later

Use real tls instead of starttls

80ea227

Owner

Webklex commented Nov 17, 2021

Hi @netpok ,
many thanks for this pull request! Great work :)

Best regards,

Webklex merged commit 14a3432 into Webklex:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment