Skip to content

Fix pagination collection from being empty #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix pagination collection from being empty #288

wants to merge 1 commit into from

Conversation

@dragonfire1119
Copy link

Solves #287
@dragonfire1119 dragonfire1119 changed the title Fix pagination collection being empty Fix pagination collection from being empty Feb 21, 2020
@Webklex
Copy link
Owner

Webklex commented Feb 26, 2020

Hi @dragonfire1119 ,
thanks for your pull request.
I can't merge it, because this would cause additional load. ::all() fetches all messages and not only the once required for the current page.

Best regards
@Webklex Webklex closed this Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@dragonfire1119 @Webklex