Skip to content

Fix shareability handling in TypeSSA collision logic #6798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2024
Merged

Fix shareability handling in TypeSSA collision logic #6798

merged 1 commit into from
Aug 1, 2024

Conversation

kripken
Copy link
Member

@kripken kripken commented Aug 1, 2024

@tlively This makes me wonder if we should consider adding a "copy" method on
TypeBuilder, to avoid needing to remember to do both setOpen/setShared in each
such place?
@kripken kripken requested a review from tlively August 1, 2024 16:07
tlively
tlively approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, some kind of copy initialization probably makes sense. I'm not sure off the top of my head whether we would need a kind of "flexible copy" that can optionally apply some mapping for the child heap types or not.
@kripken kripken merged commit 8d2c9ff into WebAssembly:main Aug 1, 2024
@kripken kripken deleted the type.ssa.shared.2 branch August 1, 2024 19:48
@kripken kripken mentioned this pull request Aug 12, 2024
Merged
@gkdn gkdn mentioned this pull request Aug 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@kripken @tlively