Use Names::getValidNameGivenExisting in binary reading #6793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| This isn't NFC as there are minor observable differences in the names compared to before, but the new names should be just as good. Added a test for collisions with the new naming scheme that prefers |
tlively approved these changes Jul 31, 2024
There was a problem hiding this comment.
Can you add this as a lit test under lit/binary instead? Although it looks a like there is already an updated lit test, so maybe it isn't necessary to add a new test at all?
There was a problem hiding this comment.
The tests check slightly different things, different possible name overlaps, with '.', '_', '$', so I think we need all three. I converted the non-lit ones to lit.
This was referenced Aug 1, 2024
kripken added a commit to emscripten-core/emscripten that referenced this pull request Aug 1, 2024
WebAssembly/binaryen#6793 alters names of functions, which two metadce tests turn out to be sensitive to. (It changes the suffixes we use to deduplicate identical names.)
kripken added a commit to emscripten-core/emscripten that referenced this pull request Aug 2, 2024
This re-enables the tests and updates the outputs. The suffixes vanish here as WebAssembly/binaryen#6793 replaces .1 with _1, and we have code in this test to ignore such suffixes (as LLVM adds them, and we strip hem to make the output less likely to change frequently).
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We had a TODO to use it once Names was optimized, which it has been.
The Names version is also far faster. When building
https://github.com/JetBrains/kotlinconf-app it saves 70 seconds(!).