Validate features for types used in tables #6768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
tlively force-pushed the validate-table-type-feats branch from 695b6dd to 2058095 Compare 
kripken approved these changes Jul 18, 2024
tlively force-pushed the threads-validate-i31ref branch from 30a41b3 to 6c0fc9b Compare tlively force-pushed the validate-table-type-feats branch from 2058095 to fb347df Compare 
We previously special-cased things like GC types, but switch to a more general solution of detecting what features a table's type requires.
tlively force-pushed the validate-table-type-feats branch from fb347df to a0f0191 Compare 
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We previously special-cased things like GC types, but switch to a more
general solution of detecting what features a table's type requires.