binaryen.js: Avoid catching exit/rejection which confuses Node error reporting #6764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sbc100 reviewed Jul 17, 2024
CMakeLists.txt Outdated
| # Avoid catching exit/rejection as that can confuse error reporting in Node, | ||
| # see https://github.com/emscripten-core/emscripten/issues/17228 | ||
| target_link_libraries(binaryen_wasm "-sNODEJS_CATCH_EXIT=0") | ||
| target_link_libraries(binaryen_wasm "-sNODEJS_CATCH_REJECTION=0") |
There was a problem hiding this comment.
NODEJS_CATCH_REJECTION is no longer needed here since it already defaults to 0 when targetting node > 15 (which is the default).
There was a problem hiding this comment.
Thanks, I verified it still works that way. Pushed.
sbc100 reviewed Jul 17, 2024
| target_link_libraries(binaryen_wasm debug "--profiling") | ||
| # Avoid catching exit as that can confuse error reporting in Node, | ||
| # see https://github.com/emscripten-core/emscripten/issues/17228 | ||
| target_link_libraries(binaryen_wasm "-sNODEJS_CATCH_EXIT=0") |
There was a problem hiding this comment.
I'm in the process of trying to disable this by default, but this change lgtm either way.
This was referenced Jul 17, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes emscripten-core/emscripten#17228
This seems the right default in binaryen.js which is used as a library through
npm mostly. We aren't a main program that wants to control node exclusively.
I verified manually that this does not interfere with our binaryen.js tests here,
just to be safe (that is, I added an error in a test and I saw the test then failed).