Remove extra space printed in empty structs #6750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kripken reviewed Jul 16, 2024
| target = pick(wasm.functions).get(); | ||
| } | ||
| if (target) { | ||
| if (heapType.isBasic()) { |
There was a problem hiding this comment.
No, from previous PRs. This PR is just the last two commits. I'll rebase and push.
| Sub = -0x30, // 0x50 | ||
| SubFinal = -0x31, // 0x4f | ||
| Shared = -0x24, // 0x65 | ||
| Shared = -0x1b, // 0x65 |
When we switched to the new type printing machinery, we inserted this extra space to minimize the diff in the test output compared with the previous type printer. Improve the quality of the printed output by removing it.
tlively force-pushed the remove-struct-space branch from eabe6db to 91a17e8 Compare 
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When we switched to the new type printing machinery, we inserted this
extra space to minimize the diff in the test output compared with the
previous type printer. Improve the quality of the printed output by
removing it.