[threads] ref.i31_shared #6735
Merged
[threads] ref.i31_shared #6735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kripken reviewed Jul 12, 2024
src/wasm.h Outdated
| RefI31() = default; | ||
| RefI31(MixedArena& allocator) {} | ||
| | ||
| Shareability share; |
There was a problem hiding this comment.
Can this not be part of the type? We don't seem to have such a field on anything else.
There was a problem hiding this comment.
See the last commmit for this change.
Implement `ref.i31_shared` the new instruction for creating references to shared i31s. Implement binary and text parsing and emitting as well as interpretation. Copy the upstream spec test for i31 and modify it so that all the heap types are shared. Comment out some parts that we do not yet support.
tlively force-pushed the threads-shared-i31 branch from 6fadc97 to f05017d Compare kripken approved these changes Jul 12, 2024
src/passes/Print.cpp Outdated
| void visitRefI31(RefI31* curr) { printMedium(o, "ref.i31"); } | ||
| void visitRefI31(RefI31* curr) { | ||
| printMedium( | ||
| o, curr->type.getHeapType().isShared() ? "ref.i31_shared" : "ref.i31"); |
There was a problem hiding this comment.
I think you may need to guard here against curr->type being unreachable (when the i32 child is unreachable), in which case getHeapType errors.
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Implement
ref.i31_sharedthe new instruction for creating referencesto shared i31s. Implement binary and text parsing and emitting as well
as interpretation. Copy the upstream spec test for i31 and modify it so
that all the heap types are shared. Comment out some parts that we do
not yet support.