StackIR: Optimize away a drop before an unreachable #6719
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Anything else right before an unreachable is removed by the main DCE pass
anyhow, but because of the structured form of BinaryenIR we can't remove a
drop. That is, this is the difference between
and
In both cases the unreachable is preceded by something we don't need, but in the latter case
it must remain in BinaryenIR for validation.
To optimize this, add a rule in StackIR.
Fixes #6715