Make it possible to skip several passes #6714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kripken reviewed Jul 8, 2024
kripken reviewed Jul 8, 2024
test/lit/passes/O1_skip_passes.wast Outdated
| (func $foo (export "foo") (param $p i32) | ||
| ;; The locals $x and $y can be coalesced into a single local, but as we do not | ||
| ;; run that pass, they will not be. Other minor optimizations will occur here, | ||
| ;; such as using a tee. |
There was a problem hiding this comment.
This comment says a tee will happen, which contradicts the previous one if I am not mistaken?
There was a problem hiding this comment.
I copied the test from O1_skip.wast but forgot to update all the comments. This is fixed.
kripken approved these changes Jul 16, 2024
test/lit/passes/O1_skip_passes.wast Outdated
| ;; CHECK-NEXT: ) | ||
| (func $foo (export "foo") (param $p i32) | ||
| ;; The locals $x and $y can be coalesced into a single local, but as | ||
| ;; we do not run that pass, they will not be. The could be |
There was a problem hiding this comment.
Suggested change
| ;; we do not run that pass, they will not be. The could be | |
| ;; we do not run that pass, they will not be. They could be |
test/lit/passes/O1_skip_passes.wast Outdated
Comment on lines 7 to 8
| ;; There should also be no warning in the output. | ||
| |
There was a problem hiding this comment.
Suggested change
| ;; There should also be no warning in the output. |
May as well delete this as the test is not verifying that atm. (It could in theory if we added additional stuff here, but I don't think it's worth it.)
kripken approved these changes Jul 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.