Add C and JS APIs to control more pass options #6713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
vouillon force-pushed the binaryen-apis branch 3 times, most recently from 9cf8471 to 28ded5b Compare Add functions to: - set and get the `trapsNeverHappen`, `closedWorld`, `generateStackIR` and `optimizeStackIR` flags - manage the list of passes to skip
kripken reviewed Jul 8, 2024
src/binaryen-c.h Outdated
| | ||
| // Test whether a pass is in the set of passes to skip. | ||
| // Applies to all modules, globally. | ||
| BINARYEN_API bool BinaryenTestPassToSkip(const char* pass); |
There was a problem hiding this comment.
We use "has" elsewhere for stuff like this, e.g. BinaryenFunctionHasLocalName, so perhaps
Suggested change
| BINARYEN_API bool BinaryenTestPassToSkip(const char* pass); | |
| BINARYEN_API bool BinaryenHasPassToSkip(const char* pass); |
There was a problem hiding this comment.
I have renamed the functions.
kripken approved these changes Jul 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add functions to:
trapsNeverHappen,closedWorld,generateStackIRandoptimizeStackIRflags