[threads] Fuzz shared types in type fuzzer #6704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Give the type fuzzer the ability to generate shared heap types when the shared-everything feature is enabled. It correctly ensures that shared structs and arrays cannot reference unshared heap types, but that unshared heap types can reference any heap type. Update the main fuzzer so that for the time being it never uses the shared-everything feature when generating additional heap types, so it never generates shared types. We can lift this restriction once the main fuzzer has been updated to properly handle shared types. As a drive-by, fix some logic for subtracting feature sets from each other that is used in this commit.
kripken approved these changes Jun 26, 2024
| if (share == Shared) { | ||
| // We can only reference other shared types. | ||
| std::vector<Index> eligible; | ||
| for (Index i = 0, n = recGroupEnds[index]; i < n; ++i) { |
There was a problem hiding this comment.
Suggested change
| for (Index i = 0, n = recGroupEnds[index]; i < n; ++i) { | |
| for (Index i = 0; i < recGroupEnds[index]; ++i) { |
That was an optimization, I assume? I trust the compiler to LICM it, so it seems better to keep the code shorter.
There was a problem hiding this comment.
I don't think the compiler will be able to prove that the contents of recGroupEnds[index] will not be modified by the loop body, and this pattern is not too rare, so I think this code is reasonable as-is.
There was a problem hiding this comment.
Fair enough. I don't feel it's a critical line to optimize but sgtm.
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Give the type fuzzer the ability to generate shared heap types when the
shared-everything feature is enabled. It correctly ensures that shared
structs and arrays cannot reference unshared heap types, but that
unshared heap types can reference any heap type.
Update the main fuzzer so that for the time being it never uses the
shared-everything feature when generating additional heap types, so it
never generates shared types. We can lift this restriction once the main
fuzzer has been updated to properly handle shared types.
As a drive-by, fix some logic for subtracting feature sets from each
other that is used in this commit.