[threads] Validate shared-to-unshared edges in heap types #6698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add spec tests checking validation for structs and arrays.
kripken approved these changes Jun 24, 2024
| break; | ||
| case HeapTypeInfo::StructKind: | ||
| for (auto& field : info.struct_.fields) { | ||
| if (field.type.isRef() && !field.type.getHeapType().isShared()) { |
There was a problem hiding this comment.
It seems surprising this only applies to references, when we have shared Memories for example, so we do have shared i32s etc. But I guess they must be referred to indirectly?
There was a problem hiding this comment.
No, we don't have separate shared i32 as a type. i32 and other non-reference types validate just fine in both shared and unshared contexts.
src/wasm-type.h Outdated
| // A continuation reference that does not refer to a function type. | ||
| InvalidFuncType, | ||
| // A non-shared field of a shared heap type. | ||
| InvalidFieldType, |
There was a problem hiding this comment.
This could perhaps be more specific? How about UnsharedFieldOfShared?
There was a problem hiding this comment.
I went with InvalidUnsharedField. I think that's more similar to existing error names.
tlively force-pushed the shared-validation branch from 4bd773a to 1722d14 Compare 
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add spec tests checking validation for structs and arrays.