Reject invalid section IDs #6675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Rather than treating them as custom sections. Also fix UB where invalid `Section` enum values could be used as keys in a map. Use the raw `uint8_t` section IDs as keys instead. Re-enable a disabled spec test that was failing because of this bug and UB.
kripken approved these changes Jun 18, 2024
src/wasm/wasm-binary.cpp Outdated
| sectionCode != BinaryConsts::Section::Code) { | ||
| if (!seenSections.insert(BinaryConsts::Section(sectionCode)).second) { | ||
| if (sectionCode != BinaryConsts::Section::Custom) { | ||
| if (!seenSections.insert(sectionCode).second) { |
There was a problem hiding this comment.
Ifs can be combined into a single if?
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Rather than treating them as custom sections. Also fix UB where invalid
Sectionenum values could be used as keys in a map. Use the rawuint8_tsection IDs as keys instead. Re-enable a disabled spec test that was failing
because of this bug and UB.