fix(#6639): fix stack-use-after-scope on windows #6643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
create a tmp var to store the childiterator to avoid use of free.
radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request Jun 5, 2024
Create a temp var to store the ChildIterator. Fixes WebAssembly#6639
radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request Jul 12, 2024
Create a temp var to store the ChildIterator. Fixes WebAssembly#6639
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR addresses #6639, moving
ChildIterator(stack[index - 1])into a local variable to avoid use after free.Tested manually on Windows and Linux, same result as expected.