SimplifyGlobals: Do not switch a get to use a global of another type #6605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
tlively approved these changes May 18, 2024
| ;; CHECK: (global $a (ref $struct) (struct.new_default $struct)) | ||
| (global $a (ref $struct) (struct.new_default $struct)) | ||
| ;; CHECK: (global $b (ref $struct) (global.get $a)) | ||
| (global $b (ref $struct) (global.get $a)) |
There was a problem hiding this comment.
What is the role of $b in this test?
There was a problem hiding this comment.
Just to be comprehensive. $c is equal to both $a and $b but in different ways (it reads $a, but it has equal content to $b). I don't think we optimize both cases atm but this would handle things if we ever did.
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
If we wanted to switch types in such cases we'd need to refinalize (which is likely
worth doing, though other passes should refine globals anyhow).
(I am adding more fuzzing for globals, which is finding these bugs.)