CFGWalker with single-thread fixes #6573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Should I add a test case using CFGWalker with single-thread in |
| Code here looks good. About a test, if it's simple to make one then it sounds like a good idea. Perhaps the test can do something like Walker walker; walker.walk(); Walker fresh; assert(walker == fresh); // walker should have no changes leftBut I'm not sure if that can work. I'd be ok landing this without a test if testing isn't easy. |
It's not easy to do such an assertion, I agree that we can merge this without a test. |
kripken approved these changes May 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fix #6557