Comment out test failing on windows #6534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| This stack of pull requests is managed by Graphite. Learn more about stacking. |
A test in spec/comments.wast is failing, but only on the Windows builder. It probably has something to do with line breaks. For now, just comment out the test. With luck, it will be fixed naturally when we update wasm-shell to parse commands using `Lexer` instead of `SExpressionParser`.
kripken approved these changes Apr 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
A test in spec/comments.wast is failing, but only on the Windows builder. It
probably has something to do with line breaks. For now, just comment out the
test. With luck, it will be fixed naturally when we update wasm-shell to parse
commands using
Lexerinstead ofSExpressionParser.