Skip to content

Add missing conversions in string slice tests #6424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Add missing conversions in string slice tests #6424

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f35a3b0
Add missing conversions in string slice tests
tlively Mar 22, 2024
0aee3b3
update checks
tlively Mar 22, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions test/lit/passes/precompute-strings.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,15 +216,19 @@
(func $slice (export "slice") (result (ref string))
;; Slicing [3:6] here should definitely output "def".
(stringview_wtf16.slice
(string.const "abcdefgh")
(string.as_wtf16
(string.const "abcdefgh")
)
(i32.const 3)
(i32.const 6)
)
)

;; CHECK: (func $slice-bad (type $2) (result (ref string))
;; CHECK-NEXT: (stringview_wtf16.slice
;; CHECK-NEXT: (string.const "abcd\c2\a3fgh")
;; CHECK-NEXT: (string.as_wtf16
;; CHECK-NEXT: (string.const "abcd\c2\a3fgh")
;; CHECK-NEXT: )
;; CHECK-NEXT: (i32.const 3)
;; CHECK-NEXT: (i32.const 6)
;; CHECK-NEXT: )
Expand All @@ -233,7 +237,9 @@
;; This slice contains non-ascii, so we do not optimize.
(stringview_wtf16.slice
;; abcd£fgh
(string.const "abcd\C2\A3fgh")
(string.as_wtf16
(string.const "abcd\C2\A3fgh")
)
(i32.const 3)
(i32.const 6)
)
Expand Down