Skip to content

Fuzz V8 Turboshaft #6360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Fuzz V8 Turboshaft #6360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion scripts/fuzz_opt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,7 +687,7 @@ def run_bynterp(wasm, args):


# default to running with liftoff enabled, because we need to pick either
# liftoff or turbofan for consistency (otherwise running the same command twice
# liftoff or turbo* for consistency (otherwise running the same command twice
# may have different results due to NaN nondeterminism), and liftoff is faster
# for small things
def run_d8_js(js, args=[], liftoff=True):
Expand Down Expand Up @@ -805,6 +805,12 @@ class D8Liftoff(D8):
def run(self, wasm):
return super(D8Liftoff, self).run(wasm, extra_d8_flags=V8_LIFTOFF_ARGS)

class D8Turboshaft(D8):
name = 'd8_turboshaft'

def run(self, wasm):
return super(D8Turboshaft, self).run(wasm, extra_d8_flags=['--no-liftoff', '--turboshaft-wasm', '--turboshaft-wasm-instruction-selection-staged'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does --turboshaft-wasm-instruction-selection-staged mean?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it means that it enables the "staged" (almost ready) part of wasm instruction selection. That's all I know, though - these are the flags that were suggested to me 😄

class D8TurboFan(D8):
name = 'd8_turbofan'

Expand Down Expand Up @@ -908,6 +914,7 @@ def can_compare_to_others(self):
self.vms = [self.bynterpreter,
D8(),
D8Liftoff(),
D8Turboshaft(),
D8TurboFan(),
# FIXME: Temprorary disable. See issue #4741 for more details
# Wasm2C(),
Expand Down