JSON: Add simple printing and creation #6265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
tlively approved these changes Feb 1, 2024
| | ||
| namespace json { | ||
| | ||
| void Value::stringify(std::ostream& os, bool pretty) { |
There was a problem hiding this comment.
This was previously declared but never defined or used?
There was a problem hiding this comment.
Yes, it just had a declaration for years... this finally starts to implement it 😄
| Added a test. |
tlively approved these changes Feb 1, 2024
radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Our barebones JSON impl will be used more in a future PR. This adds some
simple functionality to it.
It will be tested in the upcoming PR, which I can combine this into if that
would be preferable?