Rename CMake vars for modified intrinsics file #6204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
tlively approved these changes Jan 6, 2024
sbc100 reviewed Jan 6, 2024
| | ||
| static const char theModule[@WASM_INTRINSICS_SIZE@] = { | ||
| @WASM_INTRINSICS_EMBED@ | ||
| static const char theModule[@WASM_INTRINSICS_SIZE_2@] = { |
There was a problem hiding this comment.
Do you need the size here at all? Won't it be implicit?
There was a problem hiding this comment.
Yes, we should be able to leave this out.
sbc100 added a commit that referenced this pull request Jan 6, 2024
I think this is a nicer/better way to do #6204.
sbc100 added a commit that referenced this pull request Jan 6, 2024
I think this is a nicer/better way to do #6204.
radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request Jul 12, 2024
The intrinsics file changed in WebAssembly#6201 and somehow CMake doesn't automatically update itself, and needs a manual step for people with existing checkouts (a new fresh checkout always works). To avoid annoyance for existing checkouts, rename the vars, which forces CMake to recompute the contents.
radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request Jul 12, 2024
I think this is a nicer/better way to do WebAssembly#6204.
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The intrinsics file changed in #6201 and somehow CMake doesn't automatically
update itself, and needs a manual step for people with existing checkouts (a new
fresh checkout always works). To avoid annoyance for existing checkouts, rename
the vars, which forces CMake to recompute the contents.