Implement fetch transport #432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This will be used by all transports so there is no reason to duplicate code
This will simplify iteration & testing of the updated browser builds
isomorphic-unfetch is just a wrapper for node-fetch in Node, and in the browser we leave polyfilling as an exercise for the viewer. No need to ship the intermediary if we are not using its isomorphism.
Cleans up tests following removal of that library in 347e4ee
Because of how transports were previously all bound using the single shared WPAPI constructor, all tests which purported to set the transport only for one transport-specific constructor in fact all shared whichever transport was set last. To work around this, the bindTransport method has been enhanced to subclass WPAPI, and the definition of the discover method has therefore moved into that function, rather than the base wpapi.js .site() is useful regardless of whether a transport is present, so it remains in the base class; however, we override .site() with a version which provides instances of the new transport-specific subclasses when creating a new version of the constructor in bindTransport(). As a plus, this fixes the issues we had in the transport binding tests! Turns out that wasn't a false negative after all.
...What was PPP again?
kadamwhite force-pushed the implement-fetch-transport branch from 5e0456c to 2f06556 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR implements a new transport using the browser-oriented
fetchmethod, rather than our existing Node-oriented approach withsuperagent. At present we're usingisomorphic-unfetchto provide thefetchbehavior in a Node- and browser-compatible way.Possibly alias outfetchandform-datato avoid bloating browser build?