Update frequently-asked-questions.md #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
I've added a warning about the WordPress REST API being open for all Origins. I've paraphrased @rmccue to indicate this was discussed recently and to make clear who said this (instead of me). I've added a link to my plugin as an example for verifying Origins before sending out CORS headers. Trac tickets for reference: - https://core.trac.wordpress.org/ticket/40011#comment:6 - https://core.trac.wordpress.org/ticket/45477
| It looks like the ticket link is broken: |
I made a typo which caused the link to be faulty. My apologizes.
| @iandunn I fixed the link typo. It should work now. |
kadamwhite reviewed Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I've added a warning about the WordPress REST API being open for all Origins.
I've paraphrased @rmccue to indicate this was discussed recently and to make clear who said this (instead of me). I've added a link to my plugin as an example for verifying Origins before sending out CORS headers.
Trac tickets for reference: