Use filter hooks instead of accessing global variables #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
WordPress 4.6.0 respectively 4.4.0 has new filters hooks that can be used instead of accessing global variables. I also updated the old code examples to match the "books/genre" example from above.
rmccue reviewed Aug 30, 2018
rmccue requested changes Aug 30, 2018
| if ( 'book' === $post_type ) { | ||
| $args['show_in_rest'] = true; | ||
| | ||
| // Optionally customize the rest_base or rest_controller_class |
There was a problem hiding this comment.
Your indentation is off here, and the line above has extra whitespace. We should be using tabs throughout :)
| if ( 'genre' === $taxonomy_name ) { | ||
| $args['show_in_rest'] = true; | ||
| | ||
| // Optionally customize the rest_base or rest_controller_class |
| No worries. Didn't recognize it in the first place. I've fixed it and hopefully you can pass it through now ;) |
kadamwhite approved these changes Sep 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
WordPress 4.6.0 respectively 4.4.0 has new filters hooks that can be used instead of accessing global variables. I also updated the old code examples to match the "books/genre" example.