add extra directories to the docker image #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| (make sure to run |
Contributor Author
It's weird, I applied |
Contributor
| The tests seem to fail on the CI... |
Contributor Author
| Sorry about that. I was testing if scalafmt fails on wrong styles in the |
Gedochao approved these changes Oct 10, 2025
Contributor
Gedochao left a comment
Gedochao left a comment There was a problem hiding this comment.
LGTM, thanks for the contribution!
I commented on a minor nitpick.
modules/packager/src/test/scala/packager/docker/DockerPackageTests.scala Outdated Show resolved Hide resolved
…ests.scala Co-authored-by: Piotr Chabelski <ged.subfan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This feature adds the ability to include additional directories in Docker images built. Users can now specify extra directories that will be copied into the Docker image during the build process.
In the next PR to scala-cli, I would like to add a directive that supports this functionality.