Retry docs' tests on the CI #3618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Gedochao force-pushed the maintenance/retry-docs-tests branch from 709aee1 to 7f60bee Compare 
tgodzik approved these changes Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
A whole bunch of docs' tests relies on fetching nightlies or particular versions of stuff, which tends to be flaky at times. This should make it slightly more reliable.
Also, mental note to do a refactor of test utils and maybe extract them to a dedicated module, as the retry logic is now duplicated in a couple spots in the codebase.