Skip to content

Conversation

@joan38
Copy link
Contributor

@joan38 joan38 commented Aug 14, 2024

Fixes #3095

@joan38 joan38 force-pushed the package-classpath branch 2 times, most recently from 7eaaa4f to a45ce34 Compare August 14, 2024 03:32
@Gedochao
Copy link
Contributor

@joan38 joan38 force-pushed the package-classpath branch 4 times, most recently from c0487f4 to 43d5c7f Compare August 15, 2024 15:52
@joan38 joan38 force-pushed the package-classpath branch from 43d5c7f to 961f095 Compare August 15, 2024 22:43
@joan38
Copy link
Contributor Author

joan38 commented Aug 16, 2024

@Gedochao I was waiting for you to point where the tests are 😃 Thanks!
In the end the first PR version was completely wrong.
Now it's ready for review. Let me know

Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gedochao Gedochao merged commit 6080642 into VirtusLab:main Aug 19, 2024
@joan38 joan38 deleted the package-classpath branch August 22, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants