updated method for choosing a free drive letter (fixes #2743) #2749
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In order to shorten the
native-imagecommand line inWindows, it is necessary to find a free drive letter to be used as an alias forgraalvmhome.The original approach can sometimes choose a drive letter that is not actually free (details below).
The new method queries the Windows registry to identify mounted Devices.
Command line to get a list of unavailable drive letters from the registry:
See #2743 for more details.
Because the failure is a function of the Windows hardware configuration, an automated regression test might be difficult.
The fix was verified manually. Here are the before-and-after manual sessions.
The original problem session, caused by choosing
E:as a free drive letter:Here's the result with the changes (
I:is now the chosen free drive letterrather thanE:`):