Fix conflicts when watch and interactive try to read StdIn #2168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MaciejG604 changed the title 
lwronski reviewed May 29, 2023
modules/options/src/main/scala/scala/build/interactive/Interactive.scala Show resolved Hide resolved
MaciejG604 force-pushed the watch-interactive-bug branch 3 times, most recently from a50f070 to 71189a5 Compare MaciejG604 force-pushed the watch-interactive-bug branch from 71189a5 to ddd79f2 Compare lwronski reviewed May 30, 2023
modules/options/src/main/scala/scala/build/interactive/Interactive.scala Outdated Show resolved Hide resolved
MaciejG604 force-pushed the watch-interactive-bug branch 3 times, most recently from 64b0672 to 31aa3f4 Compare 
MaciejG604 force-pushed the watch-interactive-bug branch from 3aa2c59 to a8a1cd5 Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #2121
The original problem was caused by watch mode reading StdIn for
ENTERand then immediately doingStdIn.readagain, which stole the first character from what interactive mode should have read.However there's another issue with watch-interactive interaction, sometimes the watch mode reruns when sources change and should no longer read
StdIn, but theStdIn.readis not interruptible, so again it will steal first character from interactive mode.The solution from this PR fixes both problems.