React to some HTTP responses #2007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MaciejG604 force-pushed the react-to-sonatype-response-codes branch 2 times, most recently from e47336b to 4d25fcf Compare 
Gedochao reviewed Apr 18, 2023
modules/cli/src/main/scala/scala/cli/commands/publish/Publish.scala Outdated Show resolved Hide resolved
modules/cli/src/main/scala/scala/cli/commands/publish/Publish.scala Outdated Show resolved Hide resolved
MaciejG604 force-pushed the react-to-sonatype-response-codes branch from 7549774 to 52d5f6c Compare MaciejG604 force-pushed the react-to-sonatype-response-codes branch from 52d5f6c to b58eef5 Compare 
Gedochao approved these changes Nov 10, 2023
Contributor
Gedochao left a comment
Gedochao left a comment There was a problem hiding this comment.
LGTM, left some NIT comments
modules/cli/src/main/scala/scala/cli/commands/publish/Publish.scala Outdated Show resolved Hide resolved
modules/cli/src/main/scala/scala/cli/errors/InvalidSonatypePublishCredentials.scala Outdated Show resolved Hide resolved
MaciejG604 force-pushed the react-to-sonatype-response-codes branch from 5289427 to 815c93a Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We can point out possible reasons of error HTTP responses according to: https://central.sonatype.org/faq/